Uploaded image for project: 'CDAP'
  1. CDAP
  2. CDAP-14293

Move theme properties from ui-settings.json to cdap-default.xml & cdap-site.xml

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0
    • Component/s: UI
    • Labels:
      None
    • Sprint:
      5.1 09/18
    • Rank:
      1|hzy0rc:0irr007x400013d

      Description

      Currently the 'themes' directory live under cdap/cdap-ui/server/config, and the user can drag and drop a theme of their own into this directory to be applied in the UI. However, this directory will be overwritten when CDAP is upgraded. One way to get around this is to allow the user to specify a directory on their file system where their themes live, in addition to a default theme directory that we specify. This way, when CDAP is upgraded, the default theme might be changed, but the user's specified directory will not, and they can keep their customizations.

      To do this, we need to update cdap-default.xml and cdap-site.xml to have theme-related properties, such as 'ui.theme.dir' and 'ui.theme'. The 'ui.theme.dir' will be a semicolon-separated list of directories, where the user can link to their custom theme directory, and the 'ui.theme' will specify the theme UI should use. We'll also need to update the CSD and Ambari configs as well.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tbach Tony Bach
                Reporter:
                tbach Tony Bach
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: