Uploaded image for project: 'CDAP'
  1. CDAP
  2. CDAP-15417

Dark theme in cdap docs uses svg file which requires content type changes in S3

    Details

    • Type: Bug
    • Status: Open
    • Priority: Blocker
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 6.0.1
    • Component/s: Docs
    • Labels:
      None
    • Rank:
      1|i00o93:

      Description

      Dark theme in cdap docs uses svg file which requires content type changes in S3. We should use png file instead of svg file. Without this change, content type of svg file will have to be changed manually to image/svg+xml

      The paths to change the file contents are:

       cdap/6.0.0/en/_static/cdap_logo.svg
       cdap/6.0.0/en/reference-manual/_static/cdap_logo.svg
       cdap/6.0.0/en/faqs/_static/cdap_logo.svg 
       cdap/current/en/_static/cdap_logo.svg  
       cdap/current/en/reference-manual/_static/cdap_logo.svg  
       cdap/current/en/faqs/_static/cdap_logo.svg 

       

      PR:

      https://github.com/cdapio/cdap/pull/11283/files

      Reference:

      https://www.measureddesigns.com/amazon-s3-svgs-favicon-not-displaying/

       

      The corresponding change should happen in docs-site as well 

      https://github.com/cdapio/docs-site

        Attachments

          Activity

            People

            • Assignee:
              trishka Trishka
              Reporter:
              vinisha Vinisha Shah
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: