Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 3.5.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Rank:
      1|hzzmcv:

      Description

      Some usages of TableId#from(String namespace, String table) are passing the namespace as the hbase namespace, while other usages are passing in the namespace as the cdap namespace (unmapped).
      This can cause confusion and issues such as CDAP-7321.

      For example, these examples pass the CDAP namespace:
      https://github.com/caskdata/cdap/blob/release/3.5/cdap-data-fabric/src/main/java/co/cask/cdap/data/stream/StreamUtils.java#L440
      https://github.com/caskdata/cdap/blob/release/3.5/cdap-master/src/main/java/co/cask/cdap/data/tools/DatasetSpecificationUpgrader.java#L78-L78
      https://github.com/caskdata/cdap/blob/release/3.5/cdap-data-fabric/src/main/java/co/cask/cdap/data2/transaction/stream/AbstractStreamFileConsumerFactory.java#L143

      These examples pass the HBase namespace:
      https://github.com/caskdata/cdap/blob/release/3.5/cdap-data-fabric/src/main/java/co/cask/cdap/data2/transaction/queue/hbase/HBaseQueueAdmin.java#L375
      https://github.com/caskdata/cdap/blob/release/3.5/cdap-data-fabric/src/main/java/co/cask/cdap/data2/util/hbase/HBaseTableUtil.java#L184-L184

      Once the class and its usages are made consistent, appropriate javadocs should be written for the TableId class as well as all the TableUtil classes' methods.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ali.anwar Ali Anwar
                Reporter:
                ali.anwar Ali Anwar
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: