Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.9, Code Name: Ursa Major
    • Component/s: standalone
    • Labels:
      None
    • Rank:
      1|hzyo7z:

      Description

      In ~/Source/coopr_0.9.9/coopr-standalone/target/coopr-0.9.9-SNAPSHOT-standalone/server/bin/server.sh:

      lines 35 and 36 should be:

      # Determine the Java command to use to start the JVM.
      if [ -n "${JAVA_HOME}" ] ; then
      

      else it can't find JAVA_HOME.

        Activity

        Hide
        John Jackson added a comment -
        Show
        John Jackson added a comment - PR https://github.com/caskdata/coopr/pull/936 fixes this.
        Hide
        Chris Gianelloni added a comment -

        I approved the PR, but I am just curious exactly what error you're seeing... I can see a false positive, but not a false negative...

        $ echo $JAVA_HOME
        /Library/Java/JavaVirtualMachines/jdk1.7.0_71.jdk/Contents/Home
        $ if [ -n ${JAVA_HOME} ]; then echo yes ; fi
        yes
        $ if [ -n "${JAVA_HOME}" ]; then echo yes ; fi
        yes
        $ unset JAVA_HOME
        $ echo $JAVA_HOME
        
        $ if [ -n ${JAVA_HOME} ]; then echo yes ; fi
        yes
        $ if [ -n "${JAVA_HOME}" ]; then echo yes ; fi
        $ if [[ -n ${JAVA_HOME} ]]; then echo yes ; fi
        $
        
        Show
        Chris Gianelloni added a comment - I approved the PR, but I am just curious exactly what error you're seeing... I can see a false positive, but not a false negative... $ echo $JAVA_HOME /Library/Java/JavaVirtualMachines/jdk1.7.0_71.jdk/Contents/Home $ if [ -n ${JAVA_HOME} ]; then echo yes ; fi yes $ if [ -n "${JAVA_HOME}" ]; then echo yes ; fi yes $ unset JAVA_HOME $ echo $JAVA_HOME $ if [ -n ${JAVA_HOME} ]; then echo yes ; fi yes $ if [ -n "${JAVA_HOME}" ]; then echo yes ; fi $ if [[ -n ${JAVA_HOME} ]]; then echo yes ; fi $
        Hide
        John Jackson added a comment -
        [john@JJs-MacBook-Pro bin (feature/r0.9.9_doc_changes)]$ ./coopr.sh start
        
        ERROR: JAVA_HOME is set to an invalid directory: 
        
        Please set the JAVA_HOME variable in your environment to match the
        location of your Java installation.
        
        Show
        John Jackson added a comment - [john@JJs-MacBook-Pro bin (feature/r0.9.9_doc_changes)]$ ./coopr.sh start ERROR: JAVA_HOME is set to an invalid directory: Please set the JAVA_HOME variable in your environment to match the location of your Java installation.
        Hide
        John Jackson added a comment -

        What happens is that with no JAVA_HOME set, but no quotes, you get a false positive, but then it fails later on when it tests

        if [ ! -x "${JAVACMD}" ] ; then
        
        Show
        John Jackson added a comment - What happens is that with no JAVA_HOME set, but no quotes, you get a false positive, but then it fails later on when it tests if [ ! -x "${JAVACMD}" ] ; then
        Hide
        Isabela Sobral added a comment -

        PR 936

        Show
        Isabela Sobral added a comment - PR 936

          People

          • Assignee:
            John Jackson
            Reporter:
            John Jackson
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: